Too restrictive for COFF OBJ files in __create_def

alkino · June 21, 2024, 4:29pm

Hello,
I’m trying to use cmake for windows, and automatically generate symbols files definitions.

We can see in the code that a COFF file id accepted as valid if Characteristics is equal to 0, in my case this is not because I got the flag IMAGE_FILE_LINE_NUMS_STRIPPED by compiling with gcc (on windows yes).
And so this is broken.
The comment in the source code say Characteristics == 0 indicating that this is not linked COFF OBJ file, but it seems too much, right?

Here is the code:

github.com

Kitware/CMake/blob/d13afe720a9a255e81593dc125f76b465fd12265/Source/bindexplib.cxx#L448


      
            return false;
          } else {
            const PIMAGE_FILE_HEADER imageHeader = (PIMAGE_FILE_HEADER)lpFileBase;
            /* Does it look like a COFF OBJ file??? */
            if (((imageHeader->Machine == IMAGE_FILE_MACHINE_I386) ||
                 (imageHeader->Machine == IMAGE_FILE_MACHINE_AMD64) ||
                 (imageHeader->Machine == IMAGE_FILE_MACHINE_ARM) ||
                 (imageHeader->Machine == IMAGE_FILE_MACHINE_ARMNT) ||
                 (imageHeader->Machine == IMAGE_FILE_MACHINE_ARM64) ||
                 (imageHeader->Machine == IMAGE_FILE_MACHINE_ARM64EC)) &&
                (imageHeader->Characteristics == 0)) {
              /*
               * The tests above are checking for IMAGE_FILE_HEADER.Machine
               * if it contains supported machine formats (currently ARM and x86)
               * and IMAGE_FILE_HEADER.Characteristics == 0 indicating that
               * this is not linked COFF OBJ file;
               */
              DumpSymbols<IMAGE_FILE_HEADER, IMAGE_SYMBOL> symbolDumper(
                (PIMAGE_FILE_HEADER)lpFileBase, symbols, dataSymbols,
                (imageHeader->Machine == IMAGE_FILE_MACHINE_I386
                   ? Arch::I386

And here the documentation of the COFF header: IMAGE_FILE_HEADER (winnt.h) - Win32 apps | Microsoft Learn

Is it too restrictive?