Need to find/replace all #include with new path which doesn't fit with old path

al-sabr · January 30, 2021, 9:25pm

Hi I am having a problem… I took 2 external projects in another project which compile without any problem. The only problem in my code is that the old #include which are in thousands are not working anymore. I give an example:

This is the old #include style and it cannot be found the way KWSys and VNL are actually compiled and recognized by VS2019.

include <vcl_msvc_warnings.h>

it is recognized only when replaced by

include <src/vxl/vcl/vcl_msvc_warnings.h>

#include “itksys/SystemTools.hxx”

it is recognized only when replaced by

#include “src/itksys/SystemTools.hxx”

I don’t want to find and replace all the files so that it can compile…
How can I fix this bug? Did I forgot something in CMake like a command?

ben.boeckel · January 31, 2021, 3:03pm

It sounds like either some imported targets are missing interface include directories or you forgot a target_include_directories() with some variable from the project.

Cc: @jcfr

al-sabr · January 31, 2021, 3:12pm

Can you elaborate more about what you said. I kind a not understanding what are interface include directories or target_include_directories…

Here are the CMakeLists.txt files I am talking about :

github.com

al-sabr/CTK/blob/ctk-blueberry-port-from-mitk/External/KWSys/CMakeLists.txt

project(ITKKWSys)
set(ITKKWSys_THIRD_PARTY 1)

set(KWSYS_HEADER_ROOT ${ITKKWSys_BINARY_DIR}/src)
set(ITKKWSys_INCLUDE_DIRS
  ${KWSYS_HEADER_ROOT}
  )
set(ITKKWSys_LIBRARIES itksys)

# Use Unicode instead of ASCII by default
set(KWSYS_ENCODING_DEFAULT_CODEPAGE CP_UTF8)

itk_module_impl()

github.com

al-sabr/CTK/blob/ctk-blueberry-port-from-mitk/External/KWSys/src/CMakeLists.txt

set(KWSYS_NAMESPACE itksys)
set(KWSYS_USE_SystemTools 1)
set(KWSYS_USE_RegularExpression 1)
set(KWSYS_USE_Directory 1)
set(KWSYS_USE_Base64 1)
set(KWSYS_USE_MD5 1 )
set(KWSYS_USE_CommandLineArguments 1)
set(KWSYS_USE_Process 1)
if(ITK_DYNAMIC_LOADING)
  set(KWSYS_USE_DynamicLoader 1)
else()
  set(KWSYS_USE_DynamicLoader 0)
endif()
set(KWSYS_USE_Glob 1)
set(KWSYS_USE_Registry 1)
set(KWSYS_USE_SystemInformation 1)
set(KWSYS_INSTALL_INCLUDE_DIR ${ITKKWSys_INSTALL_INCLUDE_DIR})
set(KWSYS_INSTALL_LIB_DIR ${ITKKWSys_INSTALL_LIBRARY_DIR})
set(KWSYS_INSTALL_BIN_DIR ${ITKKWSys_INSTALL_RUNTIME_DIR})
set(KWSYS_INSTALL_DOC_DIR ${ITK_INSTALL_DOC_DIR})

This file has been truncated. show original

al-sabr · January 31, 2021, 3:27pm

Also this project:

github.com

al-sabr/CTK/blob/ctk-blueberry-port-from-mitk/External/VNL/CMakeLists.txt

project(ITKVNL)
set(ITKVNL_THIRD_PARTY 1)

option(ITK_USE_SYSTEM_VXL "Use an outside build of VXL." OFF)
mark_as_advanced(ITK_USE_SYSTEM_VXL)

if(ITK_USE_SYSTEM_VXL)
  find_package(VXL 3.0.0 REQUIRED)
  # 3.0.0 is the first version of VXL that supports
  # the requirement of front() and back() members
  # in the vnl_vector and vnl_vector_fixed.
  set(ITKVNL_SYSTEM_INCLUDE_DIRS
    ${VXL_NETLIB_INCLUDE_DIR}
    ${VXL_VCL_INCLUDE_DIRS}
    ${VXL_VCL_INCLUDE_DIR}
    ${VXL_CORE_INCLUDE_DIRS}
    ${VXL_CORE_INCLUDE_DIR}
    )
  set(ITKVNL_LIBRARIES vnl_algo vnl v3p_netlib netlib vcl)
  set(ITKVNL_SYSTEM_LIBRARY_DIRS "${VXL_LIBRARY_DIR}")

This file has been truncated. show original

These are not in my project but are required by my project.

This is the sub-library which is using the 2 former external projects…

github.com

al-sabr/CTK/blob/ctk-blueberry-port-from-mitk/Libs/mbilog/target_libraries.cmake

#
# See CMake/ctkFunctionGetTargetLibraries.cmake
# 
# This file should list the libraries required to build the current CTK libraries
#

set(target_libraries
  CTK
  CTKCore
  ITKKWSys
  ITKVNL
  )

if(CTK_QT_VERSION VERSION_GREATER "4")
  list(APPEND target_libraries Qt5::Core)
endif()

if (CTK_QT_VERSION VERSION_LESS "5")
  list(APPEND target_libraries QT_LIBRARIES)
endif()

al-sabr · January 31, 2021, 3:52pm

Here is the compilation log which shows clearly that many sub-targets are created by CMake and that’s why the #include paths have to be all changed…

dzenanz · February 1, 2021, 4:55pm

I don’t think your approach can work. If you only put part of ITK (part you need) into a folder in your project, there are always going to be some compile errors. To make that work, you would need to significantly alter ITK, which is harder to do than to properly incorporate it via ExternalProject_Add or some other common mechanism.

al-sabr · February 1, 2021, 5:00pm

Actually if you look at this folder I was able to extract all the features (which are minimal from ITK) and was able to make almost a full compilation.

You think that it is not possible? I think my approach is better to learn which part to modularize instead of making things monolith… what do you think?

dzenanz · February 1, 2021, 5:05pm

As ITK incorporates KWSys as part of its source code, include's reflect that in the path. If you don’t put KWSys in the same relative path that ITK expects, than you will most likely need to edit those files to put a different path, or no path, depending on what you set as include_directories in CMake code.

al-sabr · February 1, 2021, 5:22pm

As you can see the output of folder structure is the following:

How come that ITK gets the same output but can use simply the #includes and not me?

I would not like to use this kind of file path #include “src/itksys/SystemTools.hxx”
How can I remove the src and all the other subfolders in a more elegant way? It is worst with VNL which is #include <src/vxl/vcl/vcl_msvc_warnings.h>

I am not as expert as you in CMake that’s why I don’t know which direction I could go to bypass the default folder structure.