collect source lists

[ben.boeckel (Ben Boeckel (Kitware))]

For more background, see:

Add GLOBBING support to target_sources?

Currently here are 2 common patterns in our CMake codebase. Since we really like the safe globbing functionality added in 3.13. What is already possible # SAFE GLOBBING! :D file(GLOB_RECURSE sources CONFIGURE_DEPENDS *.cpp *.h) target_sources(foobar PRIVATE ${sources}) # or # SAFE GLOBBING! :D file(GLOB sources CONFIGURE_DEPENDS *.cpp *.h) target_sources(foobar PRIVATE ${sources}) Proposal I think it would be great to add this support inside target_sources # To get recursive behavior specif…

Is GLOB still considered harmful with CONFIGURE_DEPENDS?

The check costs depend on the platform (and probably generator too). I don’t know of the performance costs, but that’s because I personally find that even if it were performant, there’s at least one issue that I run into often enough to make it not worth it. I still highly discourage globbing for the reason that files may appear in your source tree that you do not intend to build. The main case I’ve run into is that during conflict resolution in git, the other versions of the file(s) in conflic…