add_library and target_include_directories

Sea_Sea · November 22, 2023, 3:50am

paullouisageneau/libdatachannel/blob/f434804c94841ed801cb96b5a7770f1f1f894276/CMakeLists.txt#L258


      
          	set(CMAKE_POLICY_DEFAULT_CMP0077 NEW)
          	add_subdirectory(deps/usrsctp EXCLUDE_FROM_ALL)
          	if (MSYS OR MINGW)
          		target_compile_definitions(usrsctp PUBLIC -DSCTP_STDINT_INCLUDE=<stdint.h>)
          	endif()
          	add_library(Usrsctp::Usrsctp ALIAS usrsctp)
          endif()
          
          add_library(datachannel SHARED
          	${LIBDATACHANNEL_SOURCES}
          	${LIBDATACHANNEL_HEADERS}
          	${LIBDATACHANNEL_IMPL_SOURCES}
          	${LIBDATACHANNEL_IMPL_HEADERS})
          set_target_properties(datachannel PROPERTIES
          	VERSION ${PROJECT_VERSION}
          	SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}
          	CXX_STANDARD 17
          	CXX_VISIBILITY_PRESET default)
          target_compile_definitions(datachannel PRIVATE RTC_EXPORTS)
          
          add_library(datachannel-static STATIC EXCLUDE_FROM_ALL

github.com

paullouisageneau/libdatachannel/blob/f434804c94841ed801cb96b5a7770f1f1f894276/CMakeLists.txt#L282


      
          	${LIBDATACHANNEL_IMPL_HEADERS})
          set_target_properties(datachannel-static PROPERTIES
          	VERSION ${PROJECT_VERSION}
          	CXX_STANDARD 17)
          target_compile_definitions(datachannel-static PRIVATE RTC_EXPORTS)
          target_compile_definitions(datachannel-static PUBLIC RTC_STATIC)
          
          target_include_directories(datachannel PUBLIC
              $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
              $<INSTALL_INTERFACE:include>)
          target_include_directories(datachannel PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/include/rtc)
          target_include_directories(datachannel PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
          target_link_libraries(datachannel PRIVATE Threads::Threads)
          target_link_libraries(datachannel PRIVATE Usrsctp::Usrsctp plog::plog)
          
          target_include_directories(datachannel-static PUBLIC
              $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
              $<INSTALL_INTERFACE:include>)
          target_include_directories(datachannel-static PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/include/rtc)
          target_include_directories(datachannel-static PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
          target_link_libraries(datachannel-static PRIVATE Threads::Threads)

add_library already use the ${CMAKE_CURRENT_SOURCE_DIR}/include/rtc
why does target_include_directories do it again?

ben.boeckel · November 22, 2023, 2:28pm

add_library just lists files for the target; there’s no -I path implied for any of them.