FindOctave.cmake in CMake Community Wiki broken for Octave 5

Community
1

Hi everyone,
I am not sure this is the right place were to discuss this, but given that the CMake Wiki is listed under “Community” in GitLab, this is my best guess.

We recently discovered that the FindOctave.cmake is broken when used with Octave 5, because in Octave 5 the support for octave-config -p PREFIX has been removed (see https://github.com/NexMirror/Octave/commit/533db703ce624136b439a19a41f406a8772b9aad#diff-659cce8e2827126070ace2206360d607).

If you don’t need the variable OCTAVE_ROOT_DIR the fix is relatively easy and it is to remove OCTAVE_ROOT_DIR from the script, see https://github.com/robotology/idyntree/pull/677/commits/571744fa4bf771b0fb755ef9f616d05d371c7b06 . However, I don’t know what is the suggested way to do modify the wiki? Discuss the changes here before?

Related discussion: github.com/robotology/idyntree/pull/677 .

2

Apparently it is also broken for Octave 4, but I had completely forgot about it: https://github.com/robotology/ycm/pull/98 .

3

@traversaro I’ve added you to the wiki project members so you can edit now. Thanks!

1 Like