CMAKE_SKIP_TEST_ALL_DEPENDENCY has the wrong default

[camio (David Sankel)]

@brad.king

[The test target] is considered a convenience for running ctest, and running ctest directly would not build all.

Thanks for that context.

@craig.scott

I’d recommend moving away from using the test build target at all and instead execute ctest directly.

That’s reasonable for the rationale you cited.

I’m concluding that it is not a best practice to include a set(CMAKE_SKIP_TEST_ALL_DEPENDENCY FALSE) line in every top-level CMakeLists.txt because:

1. It adds clutter
2. running ctest directly is preferred over usage of the test build target anyway, and
3. the test target is intended to be a shorthand for running ctest directly which is contradicted by set(CMAKE_SKIP_TEST_ALL_DEPENDENCY FALSE) semantics.